Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-10264][Documentation] Added @Since to ml.recomendation #10756

Closed
wants to merge 1 commit into from
Closed

[SPARK-10264][Documentation] Added @Since to ml.recomendation #10756

wants to merge 1 commit into from

Conversation

Wenpei
Copy link
Contributor

@Wenpei Wenpei commented Jan 14, 2016

I create new pr since original pr long time no update.
Please help to review.

@srowen

@Wenpei Wenpei changed the title [SPARK-10264][Documentation] Added Since annotation for ml.recomendation [SPARK-10264][Documentation] Added @Since to ml.recomendation Jan 14, 2016
@srowen
Copy link
Member

srowen commented Jan 14, 2016

As a continuation of #8532 it seems OK to me; I'll wait a minute to see if @mengxr wants to confirm since I haven't been involved in these kinds of changes

@Wenpei
Copy link
Contributor Author

Wenpei commented Jan 18, 2016

I guess @mengxr take a long vocation those days. Just guess from his github contribute status. :-)

@SparkQA
Copy link

SparkQA commented Jan 18, 2016

Test build #2393 has finished for PR 10756 at commit 426492e.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class ALS(@Since(\"1.4.0\") override val uid: String) extends Estimator[ALSModel] with ALSParams

@asfgit asfgit closed this in 233d6ce Jan 18, 2016
@srowen
Copy link
Member

srowen commented Jan 18, 2016

Merged to master. @Wenpei maybe you want to try finishing the other sub-issues of https://issues.apache.org/jira/browse/SPARK-7751 ?

@Wenpei Wenpei deleted the add_since_to_recomm branch January 18, 2016 13:55
@Wenpei
Copy link
Contributor Author

Wenpei commented Jan 18, 2016

Thanks @srowen. I will take a try.

ghost pushed a commit to dbtsai/spark that referenced this pull request Jan 25, 2016
@mengxr
Closes apache#10879
ef8fb36 
Closes apache#9046
Closes apache#8532
Closes apache#10756
Closes apache#8960
Closes apache#10485
Closes apache#10467
@mengxr mengxr mentioned this pull request Jan 25, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wenpei @srowen @SparkQA